feat(win): embed a manifest to allow using kanata in elevated windows #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jtroo
reviewed
Apr 17, 2024
(work in elevated windows on Windows) requires a self-signed binary (currently via an external AutoHotkey app) that can then change the manifest to have uiAccess="true"
This is done because this change adds 30 new crates which need to be downloaded and compiled. It seems wasteful to do this unless explicitly opted into, which can be done for those that desire it and for official builds. Additionally, the number of `cfg` declarations is minimized in build.rs by declaring an in-file module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Add a manifest to the kanata.exe Windows binary so that external tools can overwrite it to make it work in elevated contexts. This manifest doesn't have
uiaenabled on its own as this doesn't work with an unsigned binarySo I've also added AutoHotkey scripts that sign the binary (and enable
uia). Can also add a "compiled"EnableUIAccess.exefile to make it simpler and not require AHK installs if you wantChecklist
partially addresses #831. Fully addressing that would require adding some Windows installer that could self-sign kanata (or sign with a proper $ certificate) and add it to Program Files